fix(core): surface registry configuration errors - #3077

This is the right change for #1350 and fits EmDash's architecture well. By validating registry config while Astro evaluates the integration and by returning a safe, value-free diagnostic from the runtime manifest, it turns a generic admin 500 into a field-level banner that tells the operator what to fix.

I checked the diff against the implementation, the manifest route, the admin shell and router, the registry browse/detail components, and the relevant tests. The core retry/tests look good: malformed URLs, insecure non-local aggregators, and invalid minimumReleaseAge are all surfaced as RegistryConfigurationError diagnostics, and unexpected non-configuration failures are still rethrown rather than swallowed.

The main gap is that policy.minimumReleaseAgeExclude is not validated as an array before .map() is called, so a plausible misconfiguration (e.g., passing a bare string instead of an array) still crashes with a generic TypeError instead of a field-specific REGISTRY_MINIMUM_RELEASE_AGE_EXCLUDE_INVALID diagnostic. I also have a small suggestion to make the admin banner's switch default less misleading if new registry fields are added later.

Overall this is close to clean once the array-shape handling (and a matching test) is added.

Findings

• [needs fixing] packages/core/src/registry/config.ts:365-368

  The code assumes config.policy.minimumReleaseAgeExclude is an array and calls .map() on it without an Array.isArray() guard. If a user passes a bare string, number, or other non-array value, the normalization throws a generic TypeError: config.policy.minimumReleaseAgeExclude.map is not a function instead of the field-specific REGISTRY_MINIMUM_RELEASE_AGE_EXCLUDE_INVALID diagnostic the PR is introducing. That contradicts the goal of surfacing every malformed experimental.registry field safely.

  Validate the shape first and throw a registry configuration error, then add a unit test that asserts resolveManifestRegistryConfig returns the excluded-field code for a non-array value.

  	if (config.policy?.minimumReleaseAgeExclude !== undefined) {
  		if (!Array.isArray(config.policy.minimumReleaseAgeExclude)) {
  			throw new RegistryConfigurationError(
  				"REGISTRY_MINIMUM_RELEASE_AGE_EXCLUDE_INVALID",
  				"experimental.registry.policy.minimumReleaseAgeExclude",
  				"must be an array of DIDs or <did>/<slug> entries",
  			);
  		}
  		// Normalize at load time so callers (browser and server) can do
  		// plain string compares without each one re-implementing the
  		// case-folding rule.
  		const list = config.policy.minimumReleaseAgeExclude.map((entry) => {
  

• [suggestion] packages/admin/src/components/RegistryConfigurationBanner.tsx:19

  The default branch assumes every unknown field is experimental.registry.aggregatorUrl. The union is currently closed to three literals so this won't mislead today, but if a new diagnostic field is added later the default will silently point the user to the wrong config key. Make the aggregatorUrl case explicit and use a generic fallback, or rely on TypeScript exhaustiveness so adding a new field forces an update here.

  		switch (error.field) {
  			case "experimental.registry.aggregatorUrl":
  				description = t`Check experimental.registry.aggregatorUrl in astro.config.mjs, then restart EmDash.`;
  				break;
  			case "experimental.registry.policy.minimumReleaseAge":
  				description = t`Check experimental.registry.policy.minimumReleaseAge in astro.config.mjs, then restart EmDash.`;
  				break;
  			case "experimental.registry.policy.minimumReleaseAgeExclude":
  				description = t`Check experimental.registry.policy.minimumReleaseAgeExclude in astro.config.mjs, then restart EmDash.`;
  				break;
  		}
  

This is the right fix for #1350 and fits EmDash’s architecture well. By validating experimental.registry while Astro evaluates the integration and by having the runtime manifest route return a safe, value-free diagnostic, the change turns a generic admin 500 into a field-level banner that tells the operator exactly what to correct.

The re-review confirms the two blockers from the previous pass are resolved:

• config.policy.minimumReleaseAgeExclude is now guarded with Array.isArray() before .map(), and non-string entries also get the REGISTRY_MINIMUM_RELEASE_AGE_EXCLUDE_INVALID diagnostic.
• RegistryConfigurationBanner now handles all three known fields explicitly and falls back to a generic experimental.registry message for future/unknown fields, avoiding pointing users at the wrong config key.

I checked the diff against registry/config.ts, the runtime manifest builder, the Astro integration, EmDashManifest/AdminManifest, the admin router/Shell, the new banner component, and the unit/browser tests. The approach is sound: recognized misconfigurations surface with a stable code + field name that leaks no configured values or credentials; unexpected failures are still rethrown rather than swallowed; no new queries are added; all admin UI strings are Lingui-wrapped; the changeset is accurate and proportional for a patch.

No further blockers or nits remain—LGTM.